-
Notifications
You must be signed in to change notification settings - Fork 1.1k
PYTHON-2388 Begin PyMongo 4.0 migration guide #540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for the most part! We can add a section about FutureWarning
once we add them to UUID handling.
doc/changelog.rst
Outdated
Be sure to read the changes listed below and the :doc:`migrate-to-pymongo4` | ||
before upgrading from PyMongo 3.x. | ||
|
||
.. warning:: PyMongo 4.0 drops support for Python 2.7, 3.4, and 3.5. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: can we move this to the top of the section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
|
||
.. note:: Users of PyMongo 2.X who wish to upgrade to 4.x must first upgrade | ||
to PyMongo 3.x by following the :doc:`migrate-to-pymongo3`. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a similar note to the one above to address the unsupported interpreter versions? E.g.
.. note:: Python 2.7, 3.4, and 3.5 users who wish to upgrade to PyMongo 4.x must first upgrade to Python 3.6+. See [add link to resource] for information on upgrading Python versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add a section about FutureWarning once we add them to UUID handling.
I agree but I think we should do that in the UUID ticket itself.
doc/changelog.rst
Outdated
Be sure to read the changes listed below and the :doc:`migrate-to-pymongo4` | ||
before upgrading from PyMongo 3.x. | ||
|
||
.. warning:: PyMongo 4.0 drops support for Python 2.7, 3.4, and 3.5. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
|
||
.. note:: Users of PyMongo 2.X who wish to upgrade to 4.x must first upgrade | ||
to PyMongo 3.x by following the :doc:`migrate-to-pymongo3`. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Most of the verbiage I copied from migrate-to-pymongo3.rst. Going forward we should update this guide whenever we make a breaking change in 4.0.