RUBY-3308 Fixing serverless test failures #2770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comandeo
approved these changes
Aug 11, 2023
comandeo
pushed a commit
to comandeo/mongo-ruby-driver
that referenced
this pull request
Jan 24, 2024
* making these changes from a clean slate * propagate CRYPT_SHARED_LIB_PATH from the create-instance.sh script to run-serverless-tests.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses serverless test failures that cropped up since 7.0.0 was added as a "production release" to full.json. The problem is that the 7.0.0 entry for full.json omits the download entries, and thus the serverless tests were unable to download the crypt_shared library (because the code was relying on full.json).
It turns out, however, that crypt_shared was already being downloaded previously in the task setup, using a different approach (
download-crypt.sh). All that's needed is to propagate one of the variables forward to therun-serverless-tests.shscript, so that the script can see and use the already-downloaded crypt_shared library.So, this addresses those failures. The bad news is that the serverless tests are still failing, but now due to a different error (see https://jira.mongodb.org/browse/CLOUDP-192859). I'm putting this PR up for review anyway, since it at least fixes one issue with the serverless tests.