RUBY-3316 Quality of life updates for BSON benchmarks #2774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbevi
approved these changes
Aug 28, 2023
comandeo
pushed a commit
to comandeo/mongo-ruby-driver
that referenced
this pull request
Jan 24, 2024
* RUBY-3314 Implement variable iterations for benchmarks * report percentiles along with the median * rename Benchmarking::Micro to Benchmarking::BSON * refactoring to appease rubocop * RUBY-3315 benchmark scoring * clean up the Rakefile * progress indicator while benchmarks are running * rubocop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes here are not mandated by the spec, but make the benchmarks easier to run and monitor. The two most significant changes here are:
PROGRESSenvironment variable to 0.rake benchmark:bsonwill run all BSON benchmarks, andrake benchmark:bson:flatwill run all flat BSON benchmarks.This PR also refactors the Rake benchmark tasks to split them out into separate files.