Skip to content

DOCSP-32949: docs link to the BSON 4.x Tutorial #2784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ccho-mongodb
Copy link
Contributor

Update the link BSON v4 tutorial based on the new location.

JIRA

Note:
Docs Platform mentioned the :doc: directive should work since the file is pulled in prior to the build, but not with 100% certainty. Therefore, if it does not work as intended, a followup PR will be created to change the link format used to refer to absolute URLs.

@alexbevi alexbevi requested a review from jamis September 21, 2023 17:50
@alexbevi
Copy link
Contributor

Docs Platform mentioned the :doc: directive should work since the file is pulled in prior to the build, but not with 100% certainty. Therefore, if it does not work as intended, a followup PR will be created to change the link format used to refer to absolute URLs.

@ccho-mongodb is there no way to verify this before we sign off on a PR? Can the docs/docs-platform team fork the driver and validate this works so we can more confidently accept the changes?

@schmalliso
Copy link

Hi friends, I ran a parse locally on Chris's changes and can confirm that the :doc: link works as expected and that he's build error free. Cheers.

@alexbevi alexbevi self-requested a review September 21, 2023 19:07
Copy link
Contributor

@alexbevi alexbevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, LGTM - if @jamis agrees we'll merge this

Copy link
Contributor

@jamis jamis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well!

@jamis jamis merged commit 7fd9ad4 into mongodb:master Sep 21, 2023
jamis added a commit to jamis/mongo-ruby-driver that referenced this pull request Sep 22, 2023
* DOCSP-32949: docs link to the BSON 4.x Tutorial

* resolve link errors

---------

Co-authored-by: Jamis Buck <[email protected]>
jamis added a commit to jamis/mongo-ruby-driver that referenced this pull request Sep 22, 2023
* DOCSP-32949: docs link to the BSON 4.x Tutorial

* resolve link errors

---------

Co-authored-by: Jamis Buck <[email protected]>
jamis added a commit to jamis/mongo-ruby-driver that referenced this pull request Sep 22, 2023
* DOCSP-32949: docs link to the BSON 4.x Tutorial

* resolve link errors

---------

Co-authored-by: Jamis Buck <[email protected]>
jamis added a commit to jamis/mongo-ruby-driver that referenced this pull request Sep 22, 2023
* DOCSP-32949: docs link to the BSON 4.x Tutorial

* resolve link errors

---------

Co-authored-by: Jamis Buck <[email protected]>
jamis added a commit that referenced this pull request Sep 22, 2023
* DOCSP-32949: docs link to the BSON 4.x Tutorial

* resolve link errors

---------

Co-authored-by: Chris Cho <[email protected]>
jamis added a commit that referenced this pull request Sep 22, 2023
* DOCSP-32949: docs link to the BSON 4.x Tutorial

* resolve link errors

---------

Co-authored-by: Chris Cho <[email protected]>
jamis added a commit that referenced this pull request Sep 22, 2023
* DOCSP-32949: docs link to the BSON 4.x Tutorial

* resolve link errors

---------

Co-authored-by: Chris Cho <[email protected]>
jamis added a commit that referenced this pull request Sep 22, 2023
* DOCSP-32949: docs link to the BSON 4.x Tutorial

* resolve link errors

---------

Co-authored-by: Chris Cho <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants