RUBY-3149 Test on AWS Lambda #2800
Conversation
comandeo
force-pushed
the
3149-test-faas
branch
2 times, most recently
from
2c8833c to
1677895
Compare
comandeo
force-pushed
the
3149-test-faas
branch
from
1677895 to
0b8a747
Compare
| @@ -510,6 +514,52 @@ task_groups: | |||
| tasks: | |||
| - test-full-atlas-task | |||
There was a problem hiding this comment.
I was adding the FaaS task here, as another task under the atlas task group, so we only set up a single cluster per evergreen run. I think the fewer atlas instances we start, the better. It may be that this task group and the matrix variant that runs it need a better, more general name now, though.
There was a problem hiding this comment.
Oh, that is a great idea! Updated accordingly.
|
|
||
| cd "${TEST_LAMBDA_DIRECTORY}" | ||
|
|
||
| sam build --use-container |
| end | ||
|
|
||
| def lambda_handler(event:, context:) | ||
| db = $client.use('lambda_test') |
There was a problem hiding this comment.
Does $client need to be a global, here? Is there any reason not to instantiate the client within the handler function?
There was a problem hiding this comment.
It is recommended to have a global client instance:
Don't define a new MongoClient object each time you invoke your function. Doing so causes the driver to create a new database connection with each function call. This can be expensive and can result in your application exceeding database connection limits.
So, we need some kind of the global object here. We can work it around, i.e. using a singleton, but I'd keep it simple and dumb :-)
There was a problem hiding this comment.
Ah! I didn't know about that constraint. Never mind me, then. 👍 Looks good!
| $client.use('lambda_test').database.list_collections | ||
| puts 'Connected' | ||
|
|
||
| def reset_counters |
There was a problem hiding this comment.
The global variables make me think that maybe this should be encapsulated in an object, like a FaaSRunner class or something.
There was a problem hiding this comment.
Got rid of most of the global variables, except $client and $stats_aggregator. I think it is cleaner now, thank you!
comandeo
force-pushed
the
3149-test-faas
branch
from
2f4226c to
587d507
Compare
comandeo
force-pushed
the
3149-test-faas
branch
from
7b18028 to
e08a574
Compare
comandeo
force-pushed
the
3149-test-faas
branch
from
e08a574 to
b3d4fcc
Compare
https://jira.mongodb.org/browse/RUBY-3149
https://jira.mongodb.org/browse/RUBY-3283