Skip to content

RUST-1385 Implement explicit encryption #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Aug 24, 2022

Conversation

abr-egn
Copy link
Contributor

@abr-egn abr-egn commented Aug 17, 2022

RUST-1385

This implements the ClientEncryption struct which provides the explicit encryption API. This required a bit of refactoring to allow a Ctx to be executed independently of a Client, but is otherwise mostly just data plumbing; the API is just a wrapper around CRUD operations plus Ctx operations.

@abr-egn abr-egn marked this pull request as ready for review August 18, 2022 14:40
Copy link
Contributor

@isabelatkinson isabelatkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just one more small comment (but no need for re-review)

@abr-egn abr-egn force-pushed the RUST-1385/client-encryption branch from 8aca5b7 to bd87e86 Compare August 19, 2022 20:41
Copy link
Contributor

@kmahar kmahar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM mod typo

Co-authored-by: Kaitlin Mahar <[email protected]>
Copy link
Contributor

@patrickfreed patrickfreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@abr-egn abr-egn merged commit 6a8ac8e into mongodb:main Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants