Skip to content

RUST-1780 Bump MSRV to 1.61.0, upgrade ahash to 0.8.5 in MSRV-Cargo.lock #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 25, 2023
Merged

RUST-1780 Bump MSRV to 1.61.0, upgrade ahash to 0.8.5 in MSRV-Cargo.lock #981

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd462ae
RUST-1780 Bump MSRV to 1.61.0, upgrade `ahash` to 0.8.5 in `MSRV-Carg…
stIncMale Oct 24, 2023
6a14278
RUST-1780 Update `docs/manual` by running `mdbook build`
stIncMale Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
426 changes: 362 additions & 64 deletions .evergreen/MSRV-Cargo.lock
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion .evergreen/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,7 @@ tasks:
- func: "compile only"
vars:
# Our minimum supported Rust version. This should be updated whenever the MSRV is bumped.
RUST_VERSION: 1.60.0
RUST_VERSION: 1.61.0

- name: check-cargo-deny
tags: [lint]
Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ For more detailed documentation, see [the manual](https://mongodb.github.io/mong

## Installation
### Requirements
- Rust 1.60+ (See the [MSRV policy](#minimum-supported-rust-version-msrv-policy) for more information)
- Rust 1.61+ (See the [MSRV policy](#minimum-supported-rust-version-msrv-policy) for more information)
- MongoDB 3.6+

#### Supported Platforms
Expand Down Expand Up @@ -372,7 +372,7 @@ Commits to main are run automatically on [evergreen](https://evergreen.mongodb.c

## Minimum supported Rust version (MSRV) policy

The MSRV for this crate is currently 1.60.0. This will rarely be increased, and if it ever is,
The MSRV for this crate is currently 1.61.0. This will rarely be increased, and if it ever is,
it will only happen in a minor or major version release.

## License
Expand Down
2 changes: 1 addition & 1 deletion clippy.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
msrv = "1.60"
msrv = "1.61.0"
1 change: 1 addition & 0 deletions deny.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ allow = [
"Apache-2.0 WITH LLVM-exception",
"ISC",
"OpenSSL",
"BSD-2-Clause",
"BSD-3-Clause",
"MPL-2.0",
"Unicode-DFS-2016",
Expand Down
2 changes: 1 addition & 1 deletion docs/manual/index.html
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/manual/print.html
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/manual/searchindex.js
View file
Open in desktop
Copy link
Member Author

@stIncMale stIncMale Oct 24, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and in searchindex.json only the MSRV was updated to 1.61.0. But because both files are huge one-liners, the change is not reviewable as rendered by GitHub. How do you usually update the manual? Maybe you build it from ./manual, and then replace the whole ./docs/manual in a separate commit?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally we regenerate the contents of docs/manual in the same PR that updates manual/src; the generated files don't need to be reviewed so it's not an issue that github doesn't render them.

As a side note, we'll likely be dropping this manual entirely in the nearish future since we have official docs now :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Since this PR updates manual/src/README.md, I built the book and committed the result.

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/manual/searchindex.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion manual/src/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,5 @@ tokio::time::timeout(Duration::from_secs(5), handle).await???;

## Minimum supported Rust version (MSRV)

The MSRV for this crate is currently 1.60.0. This will rarely be increased, and if it ever is,
The MSRV for this crate is currently 1.61.0. This will rarely be increased, and if it ever is,
it will only happen in a minor or major version release.
4 changes: 2 additions & 2 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
//! # Installation
//!
//! ## Requirements
//! - Rust 1.60+
//! - Rust 1.61+
//! - MongoDB 3.6+
//!
//! ## Importing
Expand Down Expand Up @@ -289,7 +289,7 @@
//!
//! ## Minimum supported Rust version (MSRV)
//!
//! The MSRV for this crate is currently 1.60.0. This will be rarely be increased, and if it ever is,
//! The MSRV for this crate is currently 1.61.0. This will be rarely be increased, and if it ever is,
//! it will only happen in a minor or major version release.

#![warn(missing_docs)]
Expand Down