CLOUDP-61711: Validate API keys presence (#142)

Author: gssbzn

internal/cli/atlas.go

@@ -16,13 +16,17 @@ package cli
 
 import (
 	"github.com/mongodb/mongocli/internal/description"
+	"github.com/mongodb/mongocli/internal/validate"
 	"github.com/spf13/cobra"
 )
 
 func AtlasBuilder() *cobra.Command {
 	cmd := &cobra.Command{
 		Use:   "atlas",
 		Short: description.Atlas,
+		PersistentPreRunE: func(cmd *cobra.Command, args []string) error {
+			return validate.Credentials()
+		},
 	}
 	cmd.AddCommand(AtlasClustersBuilder())
 	cmd.AddCommand(AtlasDBUsersBuilder())

internal/cli/cloud_manager.go

@@ -16,6 +16,7 @@ package cli
 
 import (
 	"github.com/mongodb/mongocli/internal/description"
+	"github.com/mongodb/mongocli/internal/validate"
 	"github.com/spf13/cobra"
 )
 
@@ -24,6 +25,9 @@ func CloudManagerBuilder() *cobra.Command {
 		Use:     "cloud-manager",
 		Aliases: []string{"cm"},
 		Short:   description.CloudManager,
+		PersistentPreRunE: func(cmd *cobra.Command, args []string) error {
+			return validate.Credentials()
+		},
 	}
 
 	cmd.AddCommand(OpsManagerClustersBuilder())

internal/cli/iam.go

@@ -16,12 +16,16 @@ package cli
 
 import (
 	"github.com/mongodb/mongocli/internal/description"
+	"github.com/mongodb/mongocli/internal/validate"
 	"github.com/spf13/cobra"
 )
 
 func IAMBuilder() *cobra.Command {
 	cmd := &cobra.Command{
-		Use:   "iam",
+		Use: "iam",
+		PersistentPreRunE: func(cmd *cobra.Command, args []string) error {
+			return validate.Credentials()
+		},
 		Short: description.IAM,
 	}
 	cmd.AddCommand(IAMProjectsBuilder())

internal/cli/ops_manager.go

@@ -16,6 +16,7 @@ package cli
 
 import (
 	"github.com/mongodb/mongocli/internal/description"
+	"github.com/mongodb/mongocli/internal/validate"
 	"github.com/spf13/cobra"
 )
 
@@ -24,6 +25,9 @@ func OpsManagerBuilder() *cobra.Command {
 		Use:     "ops-manager",
 		Aliases: []string{"om"},
 		Short:   description.OpsManager,
+		PersistentPreRunE: func(cmd *cobra.Command, args []string) error {
+			return validate.Credentials()
+		},
 	}
 
 	cmd.AddCommand(OpsManagerClustersBuilder())

internal/validate/validate.go

@@ -16,9 +16,12 @@ package validate
 
 import (
 	"encoding/hex"
+	"errors"
 	"fmt"
 	"net/url"
 	"strings"
+
+	"github.com/mongodb/mongocli/internal/config"
 )
 
 func URL(val interface{}) error {
@@ -45,3 +48,10 @@ func ObjectID(s string) error {
 	}
 	return nil
 }
+
+func Credentials() error {
+	if config.PrivateAPIKey() == "" || config.PublicAPIKey() == "" {
+		return errors.New("missing credentials")
+	}
+	return nil
+}

internal/validate/validate_test.go

@@ -14,7 +14,12 @@
 
 package validate
 
-import "testing"
+import (
+	"os"
+	"testing"
+
+	"github.com/spf13/viper"
+)
 
 func TestURL(t *testing.T) {
 	t.Run("Valid URL", func(t *testing.T) {
@@ -57,3 +62,24 @@ func TestObjectID(t *testing.T) {
 		}
 	})
 }
+
+func TestCredentials(t *testing.T) {
+	t.Run("no credentials", func(t *testing.T) {
+		err := Credentials()
+		if err == nil {
+			t.Fatal("Credentials() expected an error\n")
+		}
+	})
+	t.Run("with credentials", func(t *testing.T) {
+		// this function depends on the global config (globals are bad I know)
+		// the easiest way we have to test it is via ENV vars
+		viper.AutomaticEnv()
+		_ = os.Setenv("PUBLIC_API_KEY", "test")
+		_ = os.Setenv("PRIVATE_API_KEY", "test")
+
+		err := Credentials()
+		if err != nil {
+			t.Fatalf("Credentials() unexpected error %v\n", err)
+		}
+	})
+}