Skip to content

CLOUDP-61711: Validate API keys presence #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2020
Merged

CLOUDP-61711: Validate API keys presence #142

merged 2 commits into from
Apr 30, 2020

Conversation

gssbzn
Copy link
Collaborator

@gssbzn gssbzn commented Apr 30, 2020

Proposed changes

Jira ticket: CLOUDP-61711

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

I want later on to start typing our errors so we can offer proper help depending on error but this is a quick win

@gssbzn gssbzn requested a review from andreaangiolillo April 30, 2020 10:07
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great PR! 👍

@gssbzn gssbzn merged commit d36a95e into master Apr 30, 2020
@gssbzn gssbzn deleted the CLOUDP-61711 branch April 30, 2020 10:58
corryroot pushed a commit to corryroot/mongodb-atlas-cli that referenced this pull request Jun 15, 2023
…ongodb#142)

* (DOCSP-30159) Adds release notes, source constant for v1.7.0

* Sets submodule to v1.7.0

* Adds kubernetes operator command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants