CLOUDP-56474: Validate orgIDs and projectIDs are valid values #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gssbzn
commented
Apr 17, 2020
|
|
||
| // PreRunE is a function to call before running the command, | ||
| // this will validate the project ID and call any additional function pass as a callback | ||
| func (opts *globalOpts) PreRunE(cbs ...cmdOpt) error { |
There was a problem hiding this comment.
This is our main change, we now have the validation here, and we can pass callbacks with any additional init function that the command may need
Comment on lines
+41
to
+42
| b, err := hex.DecodeString(s) | ||
| if err != nil || len(b) != 12 { |
There was a problem hiding this comment.
got this from the go mongodb client
| @@ -26,15 +26,16 @@ import ( | |||
| ) | |||
|
|
|||
| type atlasEventsListOpts struct { | |||
| globalOpts | |||
There was a problem hiding this comment.
this command wasn't using any of globalOpts functions so no need to compose it here and I'll just use the properties
colm-quinn
approved these changes
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Jira ticket: CLOUDP-56474
Checklist
make fmtand formatted my codeFurther comments
This is a small change but we had the project validation duplicated everywhere so also centralising this and using now an init function with callbacks we can reuse and extend in a better way