CLOUDP-61290: Validate base url #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gssbzn
commented
Apr 24, 2020
| @@ -37,14 +37,6 @@ type globalOpts struct { | |||
| projectID string | |||
| } | |||
|
|
|||
| func validateObjectID(s string) error { | |||
There was a problem hiding this comment.
moved to its own package
|
something seems broken in the e2e test. Do you think it is related to this changeset? |
|
@andreaangiolillo yes I need to change a setting in drone but since you have a PR I'm waiting for that as the change would break you instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Jira ticket: CLOUDP-61290
Checklist
make fmtand formatted my codeFurther comments
This is a breaking change, users will need to update their base url to include a trailing slash