-
Notifications
You must be signed in to change notification settings - Fork 86
CLOUDP-60955: mongocli om logs list #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small nits but nothing major, thanks for doing all this
} | ||
|
||
// mongocli om logs list --verbose verbose [--projectId projectId] | ||
func OpsManagerLogsListOptsBuilder() *cobra.Command { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a comment in the jira ticket about making this, maybe, mongocli om log jobs list
we could do that on a separate PR but just letting you know this may change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes I haven’t done it yet because it seems to be something that we still have to decide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've created this ticket https://jira.mongodb.org/browse/CLOUDP-61392 to keep track of this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great work
Release notes, redirects, source constant updates for v1.6.0
Proposed changes
Jira ticket: CLOUDP-60955
Checklist
make fmt
and formatted my codeFurther comments