Skip to content

CLOUDP-60955: mongocli om logs list #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 24, 2020
Merged

CLOUDP-60955: mongocli om logs list #125

merged 13 commits into from
Apr 24, 2020

Conversation

andreaangiolillo
Copy link
Collaborator

Proposed changes

Jira ticket: CLOUDP-60955

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

 ./bin/mongocli om logs list --verbose true --profile OPS
{
	"links": [
		{
			"rel": "self",
			"href": "http://localhost:8080/api/public/v1.0/groups/5ea2b3a72f3b443e64fb45fe/logCollectionJobs?verbose=true\u0026pageNum=1\u0026itemsPerPage=100"
		}
	],
	"results": [
		{
			"id": "5ea2c9dd2f3b443e64fb727d",
			"groupId": "5ea2b3a72f3b443e64fb45fe",
			"userId": "5ea2b3dd2f3b443e64fb4648",
			"creationDate": "2020-04-24T11:13:33Z",
			"expirationDate": "2020-05-24T11:13:33Z",
			"status": "SUCCESS",
			"resourceType": "replicaset",
			"resourceName": "myReplicaSet",
			"rootResourceName": "myReplicaSet",
			"rootResourceType": "replicaset",
			"downloadUrl": "http://localhost:8080/api/public/v1.0/groups/5ea2b3a72f3b443e64fb45fe/logCollectionJobs/5ea2c9dd2f3b443e64fb727d/download",
			"redacted": false,
			"logTypes": [
				"AUTOMATION_AGENT"
			],
			"sizeRequestedPerFileBytes": 64,
			"uncompressedSizeTotalBytes": 23242,
			"childJobs": [
				{
					"automationAgentId": "5ea2c9dd2f3b443e64fb727f",
					"finishDate": "2020-04-24T11:13:55Z",
					"hostName": "andreaMac",
					"logCollectionType": "AUTOMATION_AGENT",
					"path": "andreaMac/automation_agent",
					"startDate": "2020-04-24T11:13:33Z",
					"status": "SUCCESS",
					"uncompressedDiskSpaceBytes": 23242
				}
			]
		},
		{
			"id": "5ea2b69d2f3b443e64fb4b39",
			"groupId": "5ea2b3a72f3b443e64fb45fe",
			"userId": "5ea2b3dd2f3b443e64fb4648",
			"creationDate": "2020-04-24T09:51:25Z",
			"expirationDate": "2020-05-24T09:51:25Z",
			"status": "SUCCESS",
			"resourceType": "replicaset",
			"resourceName": "myReplicaSet",
			"rootResourceName": "myReplicaSet",
			"rootResourceType": "replicaset",
			"downloadUrl": "http://localhost:8080/api/public/v1.0/groups/5ea2b3a72f3b443e64fb45fe/logCollectionJobs/5ea2b69d2f3b443e64fb4b39/download",
			"redacted": false,
			"logTypes": [
				"AUTOMATION_AGENT"
			],
			"sizeRequestedPerFileBytes": 64,
			"uncompressedSizeTotalBytes": 23242,
			"childJobs": [
				{
					"automationAgentId": "5ea2b69d2f3b443e64fb4b3b",
					"finishDate": "2020-04-24T09:51:54Z",
					"hostName": "andreaMac",
					"logCollectionType": "AUTOMATION_AGENT",
					"path": "andreaMac/automation_agent",
					"startDate": "2020-04-24T09:51:25Z",
					"status": "SUCCESS",
					"uncompressedDiskSpaceBytes": 23242
				}
			]
		}
	],
	"totalCount": 2
}

@andreaangiolillo andreaangiolillo requested a review from gssbzn April 24, 2020 12:52
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nits but nothing major, thanks for doing all this

}

// mongocli om logs list --verbose verbose [--projectId projectId]
func OpsManagerLogsListOptsBuilder() *cobra.Command {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a comment in the jira ticket about making this, maybe, mongocli om log jobs list we could do that on a separate PR but just letting you know this may change

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes I haven’t done it yet because it seems to be something that we still have to decide

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've created this ticket https://jira.mongodb.org/browse/CLOUDP-61392 to keep track of this change

@andreaangiolillo andreaangiolillo requested a review from gssbzn April 24, 2020 15:52
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work

@andreaangiolillo andreaangiolillo merged commit eb4f003 into master Apr 24, 2020
@andreaangiolillo andreaangiolillo deleted the CLOUDP-60955 branch April 24, 2020 16:03
corryroot pushed a commit to corryroot/mongodb-atlas-cli that referenced this pull request Jun 15, 2023
Release notes, redirects, source constant updates for v1.6.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants