Skip to content

CLOUDP-60956: mongocli om logs download #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Apr 24, 2020
Merged

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Apr 24, 2020

Proposed changes

Jira ticket: CLOUDP-60956

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • I have tested it with my local ops manager

Further comments

@andreaangiolillo andreaangiolillo added the WIP Work in progress label Apr 24, 2020
@andreaangiolillo andreaangiolillo requested a review from gssbzn April 24, 2020 17:22
@andreaangiolillo andreaangiolillo removed the WIP Work in progress label Apr 24, 2020
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great stuff

@@ -85,10 +85,9 @@ func AtlasLogsDownloadBuilder() *cobra.Command {
fs: afero.NewOsFs(),
}
cmd := &cobra.Command{
Use: "download [hostname] [logname]",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@andreaangiolillo andreaangiolillo merged commit 7c00101 into master Apr 24, 2020
@andreaangiolillo andreaangiolillo deleted the CLOUDP-60956 branch April 24, 2020 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants