-
Notifications
You must be signed in to change notification settings - Fork 87
CLOUDP-61621: Adding the projectID in mongocli config #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of changes on copy, thanks for doing this
internal/cli/config.go
Outdated
{ | ||
Name: "projectId", | ||
Prompt: &survey.Input{ | ||
Message: "Project ID [You can leave it blank but remember to use the flag --projectId]:", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's shorter this to something like
Message: "Project ID [You can leave it blank but remember to use the flag --projectId]:", | |
Message: "Project ID [optional]:", |
internal/cli/config.go
Outdated
Name: "projectId", | ||
Prompt: &survey.Input{ | ||
Message: "Project ID [You can leave it blank but remember to use the flag --projectId]:", | ||
Help: helpLink, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
helpLink
is a link to the API docs, it won't be useful here so probably the long description you have above could be better here, something like, This is the ID or an existing project your API keys have access to, You can leave this blank and specify it on every command with --projectId
Co-Authored-By: Gustavo Bazan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* (DOCSP-26893) Adds page/section for automating processes * Includes changes from copy review
Proposed changes
Jira ticket: CLOUDP-61621
Checklist
make fmt
and formatted my codeFurther comments