Skip to content

CLOUDP-61621: Adding the projectID in mongocli config #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 29, 2020

Conversation

andreaangiolillo
Copy link
Collaborator

Proposed changes

Jira ticket: CLOUDP-61621

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@andreaangiolillo andreaangiolillo requested a review from gssbzn April 29, 2020 11:31
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of changes on copy, thanks for doing this

{
Name: "projectId",
Prompt: &survey.Input{
Message: "Project ID [You can leave it blank but remember to use the flag --projectId]:",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's shorter this to something like

Suggested change
Message: "Project ID [You can leave it blank but remember to use the flag --projectId]:",
Message: "Project ID [optional]:",

Name: "projectId",
Prompt: &survey.Input{
Message: "Project ID [You can leave it blank but remember to use the flag --projectId]:",
Help: helpLink,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

helpLink is a link to the API docs, it won't be useful here so probably the long description you have above could be better here, something like, This is the ID or an existing project your API keys have access to, You can leave this blank and specify it on every command with --projectId

@andreaangiolillo andreaangiolillo requested a review from gssbzn April 29, 2020 11:43
Co-Authored-By: Gustavo Bazan <[email protected]>
@andreaangiolillo andreaangiolillo requested a review from gssbzn April 29, 2020 11:48
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreaangiolillo andreaangiolillo merged commit 2b976c8 into master Apr 29, 2020
@andreaangiolillo andreaangiolillo deleted the CLOUDP-61621 branch April 29, 2020 11:49
corryroot pushed a commit to corryroot/mongodb-atlas-cli that referenced this pull request Jun 15, 2023
* (DOCSP-26893) Adds page/section for automating processes

* Includes changes from copy review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants