Skip to content

CLOUDP-61709: Disable usage on error #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 30, 2020
Merged

CLOUDP-61709: Disable usage on error #141

merged 2 commits into from
Apr 30, 2020

Conversation

gssbzn
Copy link
Collaborator

@gssbzn gssbzn commented Apr 30, 2020

Proposed changes

Jira ticket: CLOUDP-61709

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

This has come up a couple of times on our user research so let's do it

colm-quinn
colm-quinn approved these changes Apr 30, 2020
View reviewed changes
Copy link
Collaborator

@colm-quinn colm-quinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Give the users what they want :) LGTM.

@gssbzn gssbzn merged commit d0a44dd into master Apr 30, 2020
@gssbzn gssbzn deleted the CLOUDP-61709 branch April 30, 2020 09:20
@gssbzn gssbzn mentioned this pull request May 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colm-quinn colm-quinn colm-quinn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gssbzn @colm-quinn