CLOUDP-59267: upgrade all agents in Org #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gssbzn
requested changes
Apr 30, 2020
| @@ -36,7 +36,7 @@ func (opts *atlasDBUsersListOpts) initStore() error { | |||
|
|
|||
| func (opts *atlasDBUsersListOpts) Run() error { | |||
| listOpts := opts.newListOptions() | |||
| result, err := opts.store.DatabaseUsers(opts.projectID, listOpts) | |||
| result, err := opts.store.DatabaseUsers(opts.ProjectID(), listOpts) | |||
| opts := &opsManagerAgentsUpgradeOpts{} | ||
| cmd := &cobra.Command{ | ||
| Use: "upgrade", | ||
| Aliases: []string{"upgrade"}, |
There was a problem hiding this comment.
I think we can remove this
There was a problem hiding this comment.
I would rather change it to
Suggested change
| Aliases: []string{"upgrade"}, | |
| Aliases: []string{"upgrades"}, |
There was a problem hiding this comment.
the thing with that is that mongocli om agent upgrades breaks our usage of things like update/list/create where we don't offer updates/lists/creates, also is not fully natural in terms of grammar
gssbzn
reviewed
Apr 30, 2020
| opts := &opsManagerAgentsUpgradeOpts{} | ||
| cmd := &cobra.Command{ | ||
| Use: "upgrade", | ||
| Aliases: []string{"upgrades"}, |
There was a problem hiding this comment.
I already answer on the original but adding this alias here breaks our pattern of other commands like update/create/list where we don't offer this type of alias
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Jira ticket: CLOUDP-59267
Checklist
make fmtand formatted my codeFurther comments