Skip to content

Validate the given project ID is valid #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2020
Merged

Conversation

gssbzn
Copy link
Collaborator

@gssbzn gssbzn commented May 5, 2020

Proposed changes

Validate the given value is a valid ObjectID

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

@gssbzn gssbzn requested a review from andreaangiolillo May 5, 2020 09:20
@@ -49,6 +75,7 @@ func ObjectID(s string) error {
return nil
}

// Credentials
Copy link
Collaborator

@andreaangiolillo andreaangiolillo May 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see the purpose of this comment

Suggested change
// Credentials

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ups, committed to soon, updated

Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gssbzn gssbzn merged commit 836553b into master May 5, 2020
@gssbzn gssbzn deleted the validate-project-id branch May 5, 2020 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants