Skip to content

CLOUDP-57865: Download tar.gz / .zip diagnose archive #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
May 5, 2020
Merged

CLOUDP-57865: Download tar.gz / .zip diagnose archive #152

merged 13 commits into from
May 5, 2020

Conversation

andreaangiolillo
Copy link
Collaborator

Proposed changes

Jira ticket: CLOUDP-57865

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • I have tested my code using my local OM

Further comments

andreaangiolillo
andreaangiolillo commented May 5, 2020
View reviewed changes
@andreaangiolillo andreaangiolillo requested a review from gssbzn May 5, 2020 14:05
gssbzn
gssbzn requested changes May 5, 2020
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change with the flag, let's not make it mandatory but provide a sane default, other than that great work here

@andreaangiolillo andreaangiolillo requested a review from gssbzn May 5, 2020 15:10
gssbzn
gssbzn requested changes May 5, 2020
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, caught some small coy/paste issue

@andreaangiolillo andreaangiolillo requested a review from gssbzn May 5, 2020 15:17
gssbzn
gssbzn requested changes May 5, 2020
View reviewed changes
@andreaangiolillo andreaangiolillo requested a review from gssbzn May 5, 2020 15:25
gssbzn
gssbzn approved these changes May 5, 2020
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, sorry for not spotting all the things at the first pass

@andreaangiolillo andreaangiolillo merged commit 79cbe61 into master May 5, 2020
@andreaangiolillo andreaangiolillo deleted the CLOUDP-57865 branch May 5, 2020 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreaangiolillo @gssbzn