Add junit reports to e2e #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gssbzn
commented
May 25, 2020
| commands: | ||
| - func: "clone" | ||
| - func: "build" |
There was a problem hiding this comment.
make e2e internally builds so no need to duplicate that
| @@ -382,15 +386,23 @@ tasks: | |||
| - func: "lint" | |||
| - name: atlas_e2e | |||
| tags: ["e2e"] | |||
| depends_on: | |||
There was a problem hiding this comment.
since this depends on mcli building let's not trigger this task until we are sure we can build
| <<: *go_options | ||
| command: make e2e-test-atlas | ||
| command: make e2e-test | ||
| "cloud manager e2e": |
There was a problem hiding this comment.
this can probably be just one function with different arguments but I'll change that later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make fmtand formatted my code