CLOUDP-62054: replace mock generation in make with go generate #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| We use [mockgen](https://github.com/golang/mock) to handle mocking in our unit tests | ||
| If you need a new mock please add a reference on the [Make](Makefile) file and run `make gen-mocks` | ||
| We use [mockgen](https://github.com/golang/mock) to handle mocking in our unit tests. | ||
| If you need a new mock please update or add the `//go:generate` instruction to the appropriate file |
| @@ -30,6 +33,36 @@ type HostDescriber interface { | |||
| Host(string, string) (*opsmngr.Host, error) | |||
| } | |||
|
|
|||
| type HostDatabaseLister interface { | |||
There was a problem hiding this comment.
I don't think this should be part of this PR. You don't have to change it, it is just my opinion since this doesn't seem related to the scope of the PR.
There was a problem hiding this comment.
the reason I did it was to group the related methods and thus reducing the files to tag with go generate, if you check they all use the same opsmngr. Deployments module, this changed on the client but we never updated the file grouping so here I'm doing that, but to your point yes, they could've been a separate PR
| @@ -23,10 +23,26 @@ import ( | |||
| "go.mongodb.org/ops-manager/opsmngr" | |||
| ) | |||
|
|
|||
| //go:generate mockgen -destination=../mocks/mock_measurements.go -package=mocks github.com/mongodb/mongocli/internal/store HostMeasurementLister,HostDiskMeasurementsLister | |||
|
|
|||
| type HostMeasurementLister interface { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Jira ticket: CLOUDP-62054
Closes #[issue number]
Checklist
make fmtand formatted my code