Skip to content

CLOUDP-58568: Deleting alert configs is not asking for confirmation #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2020
Merged

CLOUDP-58568: Deleting alert configs is not asking for confirmation #36

merged 1 commit into from
Mar 6, 2020

Conversation

gssbzn
Copy link
Collaborator

@gssbzn gssbzn commented Mar 5, 2020 •
edited
Loading

Proposed changes

Jira ticket: CLOUDP-58568

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

We need to start testing stdio

@gssbzn gssbzn requested a review from andreaangiolillo March 5, 2020 18:05
andreaangiolillo
andreaangiolillo reviewed Mar 5, 2020
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have just one question.

andreaangiolillo
andreaangiolillo reviewed Mar 5, 2020
View reviewed changes
@gssbzn gssbzn merged commit a522a2d into master Mar 6, 2020
@gssbzn gssbzn deleted the CLOUDP-58568 branch March 6, 2020 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gssbzn @andreaangiolillo