Skip to content

CLOUDP-59356: Improving the deleteOpts api in Mongocli #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2020
Merged

CLOUDP-59356: Improving the deleteOpts api in Mongocli #56

merged 1 commit into from
Mar 19, 2020

Conversation

andreaangiolillo
Copy link
Collaborator

Jira ticket: CLOUDP-59356

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@andreaangiolillo andreaangiolillo requested a review from gssbzn March 19, 2020 17:18
gssbzn
gssbzn approved these changes Mar 19, 2020
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks for doing this

@andreaangiolillo andreaangiolillo merged commit ec5aa64 into master Mar 19, 2020
@andreaangiolillo andreaangiolillo deleted the CLOUDP-59356 branch March 19, 2020 17:26
corryroot pushed a commit to corryroot/mongodb-atlas-cli that referenced this pull request Jun 15, 2023
@sarahsimpers
(DOCSP-23842) Test file for automating tickets for Atlas CLI commands (…
c0d9f1d 
…mongodb#56)
corryroot pushed a commit to corryroot/mongodb-atlas-cli that referenced this pull request Jun 15, 2023
@sarahsimpers
Revert "(DOCSP-23842) Test file for automating tickets for Atlas CLI …
07e7cb7 
…commands (mongodb#56)" (mongodb#57)

This reverts commit c0d9f1d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreaangiolillo @gssbzn