CLOUDP-57306: List alerts (Atlas) #60
Conversation
andreaangiolillo
added
WIP
| Alerts(string, *atlas.AlertsListOptions) (*atlas.AlertsResponse, error) | ||
| } | ||
|
|
||
| type AlertsStore interface { |
There was a problem hiding this comment.
[qa] I do not why if I do not create the interface AlertsStore, mongocli atlas alert describe alertID seems using the wrong interface (it returns a list instead of one alert)
internal/cli/atlas_alerts_list.go
Outdated
|
|
||
| cmd.Flags().IntVar(&opts.pageNum, flags.Page, 0, usage.Page) | ||
| cmd.Flags().IntVar(&opts.itemsPerPage, flags.Limit, 0, usage.Limit) | ||
| cmd.Flags().StringVar(&opts.status, flags.Status, "", usage.Status) |
There was a problem hiding this comment.
Thanks for making this effort but let's make this work without the filter for now and let's create a ticket linking the dependency on mongodb/go-client-mongodb-atlas#69
this let us have something working and we can later add more features
There was a problem hiding this comment.
Can I just comment out the piece of code related to the status? or do you want me to delete it
There was a problem hiding this comment.
This line in particular can be commented if you want, but I saw that you changed the signature of the API so for that we can't do anything about it 🤷♂
|
|
||
| cmd.Flags().IntVar(&opts.pageNum, flags.Page, 0, usage.Page) | ||
| cmd.Flags().IntVar(&opts.itemsPerPage, flags.Limit, 0, usage.Limit) | ||
| //cmd.Flags().StringVar(&opts.status, flags.Status, "", usage.Status) |
There was a problem hiding this comment.
can you please add a // TODO: CLOUDP-N for the ticket where we'll fix this so people know why this is commented and when we plan to fix it?
| } | ||
|
|
||
| }) | ||
| // t.Run("List with status OPEN", func(t *testing.T) { |
There was a problem hiding this comment.
Let's add a TODO here as well linking to jira
(DOCSP-24168) AtlasCLI version 1.1.5
Jira ticket: CLOUDP-57306
Checklist
make fmtand formatted my codeFurther comments