CLOUDP-59567: Adding the support of alerts for OM in mcli #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gssbzn
reviewed
Mar 24, 2020
| github.com/mongodb/go-client-mongodb-ops-manager v0.0.2-0.20200319100114-648fc659365b | ||
| github.com/mongodb/go-client-mongodb-atlas v0.1.4-0.20200323160302-12cb92c69adf | ||
| github.com/mongodb/go-client-mongodb-ops-manager v0.0.2-0.20200324155204-287d08b2e57b | ||
| github.com/mwielbut/pointy v1.1.0 |
There was a problem hiding this comment.
any reason to include pointy now? can you please check this? will it compile if we remove this line?
There was a problem hiding this comment.
I think I'm getting this on master as well, so may as well 🤷♂
There was a problem hiding this comment.
go mod tidy does not clean pointy but the application compiles without it. I do not how ponty went there 🤦♂
There was a problem hiding this comment.
If I remove ponty from go.mod and then run make fmt check build, ponty is again inside go.mod
There was a problem hiding this comment.
Found the why, you added it to a fixture
gssbzn
approved these changes
Mar 24, 2020
corryroot
pushed a commit
to corryroot/mongodb-atlas-cli
that referenced
this pull request
Jun 15, 2023
* Adds release notes for 1.1.6 and 1.1.7, updates source constant * Sets submodule to atlascli/v1.1.7 * Includes change from Julia's copy review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: CLOUDP-59567
Checklist
make fmtand formatted my codeFurther comments