Skip to content

CLOUDP-57842: Update alert configs, Atlas #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 27, 2020
Merged

CLOUDP-57842: Update alert configs, Atlas #70

merged 8 commits into from
Mar 27, 2020

Conversation

andreaangiolillo
Copy link
Collaborator

Proposed changes

Jira ticket: CLOUDP-57842

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • I have tested it by creating/running the e2e test on the cloud-dev env

Further comments

@andreaangiolillo andreaangiolillo requested a review from gssbzn March 26, 2020 13:16
gssbzn
gssbzn reviewed Mar 26, 2020
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One not so small change but in general this looks ok

@andreaangiolillo andreaangiolillo requested a review from gssbzn March 26, 2020 16:09
gssbzn
gssbzn requested changes Mar 26, 2020
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of things with the refactor but this is better than embedding the whole document

@andreaangiolillo andreaangiolillo requested a review from gssbzn March 26, 2020 17:52
gssbzn
gssbzn requested changes Mar 26, 2020
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there, we can remove a little line and add it back to where is needed

gssbzn
gssbzn reviewed Mar 26, 2020
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are some nil pointer exceptions on the e2e

@andreaangiolillo andreaangiolillo requested a review from gssbzn March 27, 2020 08:13
@andreaangiolillo andreaangiolillo mentioned this pull request Mar 27, 2020
Merged
5 tasks
gssbzn
gssbzn approved these changes Mar 27, 2020
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff 💯

@andreaangiolillo andreaangiolillo merged commit 700b5e0 into master Mar 27, 2020
@andreaangiolillo andreaangiolillo deleted the CLOUDP-57842 branch March 27, 2020 10:04
corryroot pushed a commit to corryroot/mongodb-atlas-cli that referenced this pull request Jun 15, 2023
@kanchana-mongodb
Merge pull request mongodb#70 from kanchana-mongodb/DOCSP-25235
e48f112 
DOCSP-25235 Add section on how to specifying a config file path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreaangiolillo @gssbzn