CLOUDP-59682: Enable security on C/OM #75
Conversation
| make fmt check | ||
| STAGED_GO_FILES=$(git diff --cached --name-only | grep ".go$") | ||
|
|
||
| for FILE in $STAGED_GO_FILES |
There was a problem hiding this comment.
[qa] Does this piece of code format your files before the commit?
There was a problem hiding this comment.
yes, if you install it, it was taking a lot of time in my machine so I changed to only do it for staged files, should improve speed a little
| globalOpts: newGlobalOpts(), | ||
| } | ||
| cmd := &cobra.Command{ | ||
| Use: "enable [MONGODB-CR|SCRAM-SHA-256]", |
There was a problem hiding this comment.
[qa] why aren't we passing the authentication mechanism as an argument?
There was a problem hiding this comment.
what do you mean here exactly?
There was a problem hiding this comment.
Could you explain to me what this enable[MONGODB-CR|SCRAM-SHA-256] mean? Is enable using an argument which can be set as MONGODB-CR or SCRAM-SHA-256 (I do not think so because you are not setting an argument), or, is the command enable always used in the form enable [MONGODB-CR|SCRAM-SHA-256]?
There was a problem hiding this comment.
the values can be, MONGODB-CR, SCRAM-SHA-256 or both at the same time, check line 78
|
@andreaangiolillo did a small change here so RFAL |
Proposed changes
Jira ticket: CLOUDP-59682
Checklist
make fmtand formatted my code