Skip to content

Commit 5732b52

Browse files
test(NODE-5862): skip transaction unpin TransientTransactionErrors spec tests (#4024)
1 parent cbaf47a commit 5732b52

File tree

1 file changed

+18
-4
lines changed

1 file changed

+18
-4
lines changed

Diff for: test/integration/transactions/transactions.spec.test.js

+18-4
Original file line numberDiff line numberDiff line change
@@ -78,11 +78,25 @@ class TransactionsRunnerContext extends TestRunnerContext {
7878
}
7979
}
8080

81+
const UNIFIED_SKIP_TESTS = [
82+
'unpin after TransientTransactionError error on commit',
83+
'unpin on successful abort',
84+
'unpin after non-transient error on abort',
85+
'unpin after TransientTransactionError error on abort',
86+
'unpin when a new transaction is started',
87+
'unpin when a non-transaction write operation uses a session',
88+
'unpin when a non-transaction read operation uses a session'
89+
];
90+
8191
describe('Transactions Spec Unified Tests', function () {
82-
runUnifiedSuite(loadSpecTests(path.join('transactions', 'unified')));
92+
runUnifiedSuite(loadSpecTests(path.join('transactions', 'unified')), test =>
93+
UNIFIED_SKIP_TESTS.includes(test.description)
94+
? 'TODO(NODE-5855): Unskip Transactions Spec Unified Tests mongos-unpin.unpin'
95+
: false
96+
);
8397
});
8498

85-
const SKIP_TESTS = [
99+
const LEGACY_SKIP_TESTS = [
86100
// TODO(NODE-3943): Investigate these commit test failures
87101
// OLD COMMENT: commitTransaction retry seems to be swallowed by mongos in these two cases
88102
'commitTransaction retry fails on new mongos',
@@ -97,7 +111,7 @@ describe('Transactions Spec Legacy Tests', function () {
97111
const testContext = new TransactionsRunnerContext();
98112
if (process.env.SERVERLESS) {
99113
// TODO(NODE-3550): these tests should pass on serverless but currently fail
100-
SKIP_TESTS.push(
114+
LEGACY_SKIP_TESTS.push(
101115
'abortTransaction only performs a single retry',
102116
'abortTransaction does not retry after Interrupted',
103117
'abortTransaction does not retry after WriteConcernError Interrupted',
@@ -114,7 +128,7 @@ describe('Transactions Spec Legacy Tests', function () {
114128
});
115129

116130
function testFilter(spec) {
117-
return SKIP_TESTS.indexOf(spec.description) === -1;
131+
return LEGACY_SKIP_TESTS.indexOf(spec.description) === -1;
118132
}
119133

120134
generateTopologyTests(testSuites, testContext, testFilter);

0 commit comments

Comments
 (0)