Skip to content

test(NODE-5862): skip transaction unpin TransientTransactionErrors spec tests #4024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 8, 2024

Conversation

aditi-khare-mongoDB
Copy link
Contributor

@aditi-khare-mongoDB aditi-khare-mongoDB commented Mar 6, 2024

Description

Skip transaction unpin TransientTransactionError tests on the 5.x branch, so that the build failures do not clutter the CI.

What is changing?

Skip relevant tests on 5.x

Is there new documentation needed for these changes?

No.

What is the motivation for this change?

Build failure described in NODE-5852
For 5.x, we are skipping all versions (not just latest like on 6.x) to clear CI.

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@aditi-khare-mongoDB aditi-khare-mongoDB changed the base branch from main to 5.x March 6, 2024 21:29
@aditi-khare-mongoDB aditi-khare-mongoDB force-pushed the NODE-5862/5.x-build-failure-backport branch from 4f8e822 to 522d49a Compare March 6, 2024 21:42
@aditi-khare-mongoDB aditi-khare-mongoDB changed the title test(NODE-5862): 5.x - Skip transaction unpin spec tests test(NODE-5862): 5.x - Skip transaction unpin spec tests on latest Mar 6, 2024
@nbbeeken nbbeeken changed the title test(NODE-5862): 5.x - Skip transaction unpin spec tests on latest test(NODE-5862): skip transaction unpin spec tests on latest Mar 7, 2024
@aditi-khare-mongoDB aditi-khare-mongoDB changed the title test(NODE-5862): skip transaction unpin spec tests on latest test(NODE-5862): skip transaction unpin TransientTransactionErrors spec tests Mar 7, 2024
@aditi-khare-mongoDB aditi-khare-mongoDB force-pushed the NODE-5862/5.x-build-failure-backport branch 3 times, most recently from bf0937f to fd34935 Compare March 7, 2024 19:37
@aditi-khare-mongoDB aditi-khare-mongoDB changed the title test(NODE-5862): skip transaction unpin TransientTransactionErrors spec tests test(NODE-5862): 5.x - skip transaction unpin TransientTransactionErrors spec tests Mar 7, 2024
@aditi-khare-mongoDB aditi-khare-mongoDB marked this pull request as ready for review March 7, 2024 22:02
@nbbeeken nbbeeken self-assigned this Mar 8, 2024
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Mar 8, 2024
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just need:

File follow-up to unskip

from the AC

@nbbeeken nbbeeken changed the title test(NODE-5862): 5.x - skip transaction unpin TransientTransactionErrors spec tests test(NODE-5862): skip transaction unpin TransientTransactionErrors spec tests Mar 8, 2024
@aditi-khare-mongoDB
Copy link
Contributor Author

Here's the follow-up:NODE-6006

@nbbeeken nbbeeken merged commit 5732b52 into 5.x Mar 8, 2024
1 of 2 checks passed
@nbbeeken nbbeeken deleted the NODE-5862/5.x-build-failure-backport branch March 8, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants