Skip to content

test: legacy spec runner improvements #2917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 23, 2021
Merged

test: legacy spec runner improvements #2917

merged 3 commits into from
Jul 23, 2021

Conversation

emadum
Copy link
Contributor

@emadum emadum commented Jul 23, 2021

  • Allow skipped tests to skip beforeEach/afterEach hooks, significantly speeding up test runs particularly against remote servers with higher latency.
  • Fixes a bug in the URL returned by the legacy test runner when isShardedEnvironment && !useMultipleMongoses

@emadum emadum requested a review from dariakp July 23, 2021 16:29
@emadum emadum added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jul 23, 2021
@dariakp dariakp self-assigned this Jul 23, 2021
dariakp
dariakp approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, though maybe we should file a ticket for that outstanding TODO

@dariakp dariakp added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jul 23, 2021
@dariakp dariakp requested a review from nbbeeken July 23, 2021 17:57
@emadum emadum force-pushed the spec-runner-fixes/4.0 branch from 524abcf to 43d5841 Compare July 23, 2021 19:00
nbbeeken
nbbeeken approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dariakp dariakp merged commit c67daea into 4.0 Jul 23, 2021
@dariakp dariakp deleted the spec-runner-fixes/4.0 branch July 23, 2021 19:51
ljhaywar pushed a commit that referenced this pull request Nov 9, 2021
@emadum @ljhaywar
test: legacy spec runner improvements (#2917)
323c26c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

@dariakp dariakp dariakp approved these changes

Assignees

@dariakp dariakp

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emadum @nbbeeken @dariakp