test(NODE-4059): Change Stream test typescripting and unified builder fixes #3224
Conversation
nbbeeken
changed the title
| @@ -1,18 +1,17 @@ | |||
| 'use strict'; | |||
| import { expect } from 'chai'; | |||
| import * as path from 'path'; | |||
There was a problem hiding this comment.
This is entirely unrelated to your PR but this is something I've wondered. I see we sometimes use import * as path from 'path' but we don't import other NodeJS modules the same way. Is there a reason we don't destructure path specifically?
There was a problem hiding this comment.
I prefer doing this for path beacuse join is such a genericly named function, so path.join is more indicative of the functionality. It's not like we have many joins runnning around though.
| const dbName = 'changestream_integration_test'; | ||
| const collectionName = 'test'; | ||
|
|
||
| // TODO remove withClient and withChangeStream usage, use mocha hooks |
There was a problem hiding this comment.
Do we have a jira ticket to go with this TODO? Otherwise, can we create one?
| fullDocument: 'updateLookup', | ||
| // @ts-expect-error: NODE-XXXX is this a type bug? requires locale |
There was a problem hiding this comment.
did you mean to link https://jira.mongodb.org/browse/NODE-4081?
There was a problem hiding this comment.
I looked it up this was just incorrect usage, you need to pass in a locale
Description
What is changing?
Break out of test changes for #3191
Is there new documentation needed for these changes?
What is the motivation for this change?
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>