test(NODE-4648): pull prepare shell out to script and fix reporter error handling #3418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
force-pushed
the
chore/pull-out-scripts-from-yml
branch
from
397e734 to
c92c0e2
Compare
nbbeeken
changed the title
nbbeeken
force-pushed
the
chore/pull-out-scripts-from-yml
branch
from
1232985 to
41dc220
Compare
nbbeeken
changed the title
nbbeeken
changed the title
dariakp
reviewed
Sep 16, 2022
nbbeeken
changed the title
|
this patch runs the entire waterfall to double check these changes work correctly on all platforms / setups: |
|
We're passing everything, the mongosh tests don't use our env setup |
dariakp
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Yoinks prepare-shell out of our yml to make it easily runnable when using spawn hosts.
Our prepare script is currently embedded in our evergreen yml. Pulling it out makes running it locally and on spawn hosts much easier.
Additionally, while attempting pulling out this script it was discovered one of our tasks is failing a lot of tests but reporting success (NODE-4642). It turns out errors thrown from mocha reporters are squashed (visually) but still exit the process, but with success. It's a small change to add error handling to our reporter.
While we're adding error handling to the reporter we should remove stdout/err capturing. We don't use it, and it doesn't correctly work on evergreen, and it make xunit.xml huge.
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>