test(NODE-5852): Skip transaction unpin spec tests #3980
Conversation
nbbeeken
added
the
Primary Review
| 'Client side error when transaction is in progress', | ||
|
|
||
| // TODO(NODE-5855): Unskip Transactions Spec Unified Tests mongos-unpin.unpin | ||
| 'unpin after TransientTransactionError error on commit', |
There was a problem hiding this comment.
We discussed only skipping on latest, which is a smoke test anyway, these tests still pass for servers that are used in production, we can continue to make sure these work on those servers.
There was a problem hiding this comment.
Thanks for the reminder, I've changed it to skipped on latest.
There was a problem hiding this comment.
I still see the test failing in EVG:
Is the server version correct?
There was a problem hiding this comment.
I meant I skipped it within the code.
nbbeeken
changed the title
|
It seems 'when a new transaction is started' also occasionally fails on latest. I updated this PR and the corresponding ticket to include this test. At this point, I wonder if its safer to just skip all transaction unpin tests. |
|
Just noticed 'Unpin when a non transaction user uses a session' is also flaky. |
Description
Skip transaction unpin tests related to a build failure.
What is changing?
Skip relevant tests.
Is there new documentation needed for these changes?
No.
What is the motivation for this change?
Build failure described in NODE-5852
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript