Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NODE-5815): remove oidc #3981

Merged
merged 1 commit into from
Jan 26, 2024
Merged

feat(NODE-5815): remove oidc #3981

merged 1 commit into from
Jan 26, 2024

Conversation

durran
Copy link
Member

@durran durran commented Jan 26, 2024

Description

Removes the experimental OIDC feature from the 5.x branch.

What is changing?

Removes all OIDC functionality, Evergreen configurations, and tests.

Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-5815

Experimental OIDC functionality removed

This mechanism was added for experimental testing only.

Important

This release includes some experimental features that are not yet ready for use. As a reminder, anything marked experimental is not a part of the stable driver API and is subject to change without notice.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran force-pushed the NODE-5815 branch 3 times, most recently from a749af5 to df7f00e Compare January 26, 2024 15:20
@durran durran marked this pull request as ready for review January 26, 2024 15:55
@nbbeeken nbbeeken self-assigned this Jan 26, 2024
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jan 26, 2024
@nbbeeken nbbeeken self-requested a review January 26, 2024 16:45
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, but can you put some informative release notes in,

Aprox. hitting these highlights:
~this was experimental, which means not for production
~the implementation is not maintained

Just to be clear about why the changes are being made.

@durran
Copy link
Member Author

durran commented Jan 26, 2024

Changes LGTM, but can you put some informative release notes in,

Aprox. hitting these highlights: ~this was experimental, which means not for production ~the implementation is not maintained

Just to be clear about why the changes are being made.

I actually didn't want it in the release notes as it was never publicly announced, and would now then show up in our public release notes. Maybe we just make it a chore instead?

@durran durran requested a review from nbbeeken January 26, 2024 17:12
@nbbeeken
Copy link
Contributor

Sure also we can edit the PR later if we want to add something.

@durran durran changed the title feat(NODE-5815): remove oidc chore(NODE-5815): remove oidc Jan 26, 2024
@nbbeeken nbbeeken changed the title chore(NODE-5815): remove oidc feat(NODE-5815): remove oidc Jan 26, 2024
@nbbeeken nbbeeken merged commit 4893330 into 5.x Jan 26, 2024
@nbbeeken nbbeeken deleted the NODE-5815 branch January 26, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants