Skip to content

chore(NODE-6502) Use a python venv wherever we use Python in driver CI #4325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 commented Nov 12, 2024

(cherry picked from commits db4eff5 and 247284e)

What is changing?

Use scripts from drivers-evergreen-tools instead of using the system python package manager.

Is there new documentation needed for these changes?

No

What is the motivation for this change?

Some places in Node's CI we rely on the system python/pip, which can lead to compatibility issues when we call drivers-evergreen-tools scripts and broken CI.

Release Highlight

Fill in title or leave empty for no highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint also failing on 5.x

@baileympearson baileympearson merged commit 1d1c165 into mongodb:5.x Nov 13, 2024
22 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants