ci(NODE-6682, NODE-6684): deployed KMS tests and serverless tests use secrets manager #4385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
force-pushed
the
fle-kms
branch
from
e97d096 to
3e19043
Compare
baileympearson
changed the title
5 tasks
durran
added
the
Primary Review
durran
reviewed
Jan 29, 2025
durran
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Serverless tests use AWS secrets manager to fetch credentials to set up the cluster. These tests don't use secretes manager to fetch FLE credentials (https://jira.mongodb.org/browse/NODE-6685).
GCP and Azure KMS e2e tests also use secrets manager.
I also updated the testing readme with instructions on how to use secrets manager and how to run these tests locally.
Is there new documentation needed for these changes?
No.
What is the motivation for this change?
Release Highlight
Fill in title or leave empty for no highlight
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript