Skip to content

test(NODE-6835): IPv6 literal in SDAM #4482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 25, 2025
Merged

test(NODE-6835): IPv6 literal in SDAM #4482

merged 2 commits into from
Mar 25, 2025

Conversation

nbbeeken
Copy link
Contributor

Description

What is changing?

Sync tests from mongodb/specifications@fc495d5

NODE-6835

Is there new documentation needed for these changes?

No

What is the motivation for this change?

spec compat

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken requested a review from a team as a code owner March 24, 2025 20:35
@baileympearson baileympearson self-assigned this Mar 24, 2025
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Mar 24, 2025
baileympearson
baileympearson approved these changes Mar 24, 2025
View reviewed changes
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing in CI: https://parsley.mongodb.com/evergreen/mongo_node_driver_next_lint_run_unit_tests_node_20_patch_5ce0a4ec855fd1d609fbb17f85b014e5b0fa8157_67e1c20f7ca36e0006d8749f_25_03_24_20_35_28/0/task?bookmarks=0,5105&shareLine=557

@baileympearson
Copy link
Contributor

Some transient CI failures yesterday, waiting on the most recent CI run after updating the branch.

@baileympearson baileympearson merged commit d01ecc7 into main Mar 25, 2025
27 of 28 checks passed
@baileympearson baileympearson deleted the NODE-6835-ipv6-sdam branch March 25, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baileympearson baileympearson baileympearson approved these changes

Assignees

@baileympearson baileympearson

Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbbeeken @baileympearson