Skip to content

types(ModifyResult): update lastErrorObject #4493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

moshfeu
Copy link

@moshfeu moshfeu commented Mar 28, 2025

This pull request includes a modification to the ModifyResult interface in the src/collection.ts file to provide more detailed information about the last error object.

Changes to ModifyResult interface:

  • src/collection.ts: Updated the lastErrorObject property in the ModifyResult interface to include more specific fields: n, updatedExisting, and upserted.

https://www.mongodb.com/docs/manual/reference/command/findAndModify/#lasterrorobject

Description

What is changing?

Is there new documentation needed for these changes?

What is the motivation for this change?

Release Highlight

Fill in title or leave empty for no highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
snyk-bot Snyk bot
@baileympearson
Copy link
Contributor

@moshfeu Are you intending to open this PR?

@moshfeu
Copy link
Author

moshfeu commented Apr 11, 2025

Hi @baileympearson

I will do it eventually :) I just didn't have the time to go through test steps in "Double check the following".

@baileympearson
Copy link
Contributor

@moshfeu Okay! That's fine, take your time. But would you mind closing this PR until you're ready to open it for review?

@moshfeu moshfeu closed this Apr 11, 2025
@moshfeu
Copy link
Author

moshfeu commented Apr 11, 2025

Sure, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants