Skip to content

poc: flatten #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/cli/Makefile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# A Self-Documenting Makefile: http://marmelab.com/blog/2016/02/29/auto-documented-makefile.html

GOLANGCI_VERSION=v1.64.5
GOLANGCI_VERSION=v1.64.7
SOURCE_FILES?=./cmd
BINARY_NAME=foascli
VERSION=v0.0.1
Expand Down
46 changes: 46 additions & 0 deletions tools/cli/internal/cli/flatten/flatten.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
package flatten

import (
"fmt"

Check failure on line 4 in tools/cli/internal/cli/flatten/flatten.go

View workflow job for this annotation

GitHub Actions / lint

File is not properly formatted (gci)
"github.com/getkin/kin-openapi/openapi3"
"github.com/mongodb/openapi/tools/cli/internal/cli/flag"
"github.com/mongodb/openapi/tools/cli/internal/cli/usage"
"github.com/spf13/cobra"
"github.com/tufin/oasdiff/flatten/allof"
"gopkg.in/yaml.v3"
)

func Builder() *cobra.Command {
var spec string

cmd := &cobra.Command{
Use: "flatten -s <spec>",
Short: "Flatten the spec.",
Args: cobra.NoArgs,

RunE: func(_ *cobra.Command, _ []string) error {
loader := openapi3.NewLoader()
loader.IsExternalRefsAllowed = true
specInfo, err := loader.LoadFromFile(spec)

Check failure on line 24 in tools/cli/internal/cli/flatten/flatten.go

View workflow job for this annotation

GitHub Actions / lint

ineffectual assignment to err (ineffassign)
//spec, err := load.NewSpecInfo(loader, spec, load.WithFlattenAllOf())

Check failure on line 25 in tools/cli/internal/cli/flatten/flatten.go

View workflow job for this annotation

GitHub Actions / lint

commentFormatting: put a space between `//` and comment text (gocritic)
//loader := openapi.NewOpenAPI3()
//specInfo, err := loader.CreateOpenAPISpecFromPath(spec)
//if err != nil {
// return err
//}
result, err := allof.MergeSpec(specInfo)
if err != nil {
return err
}
yamlData, err := yaml.Marshal(result)

Check failure on line 35 in tools/cli/internal/cli/flatten/flatten.go

View workflow job for this annotation

GitHub Actions / lint

ineffectual assignment to err (ineffassign)
fmt.Print(string(yamlData))
return nil
},
}

cmd.Flags().StringVarP(&spec, flag.Spec, flag.SpecShort, "-", usage.Spec)

_ = cmd.MarkFlagRequired(flag.Spec)

return cmd
}
5 changes: 3 additions & 2 deletions tools/cli/internal/cli/root/openapi/builder.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,18 @@
package openapi

import (
"fmt"

Check failure on line 18 in tools/cli/internal/cli/root/openapi/builder.go

View workflow job for this annotation

GitHub Actions / lint

File is not properly formatted (gci)
"runtime"

"github.com/mongodb/openapi/tools/cli/internal/cli/breakingchanges"
"github.com/mongodb/openapi/tools/cli/internal/cli/changelog"
"github.com/mongodb/openapi/tools/cli/internal/cli/filter"
"github.com/mongodb/openapi/tools/cli/internal/cli/flatten"
"github.com/mongodb/openapi/tools/cli/internal/cli/merge"
"github.com/mongodb/openapi/tools/cli/internal/cli/split"
"github.com/mongodb/openapi/tools/cli/internal/cli/sunset"
"github.com/mongodb/openapi/tools/cli/internal/cli/versions"
"github.com/mongodb/openapi/tools/cli/internal/version"
"github.com/spf13/cobra"
"runtime"
)

const (
Expand Down Expand Up @@ -63,6 +63,7 @@
breakingchanges.Builder(),
sunset.Builder(),
filter.Builder(),
flatten.Builder(),
)
return rootCmd
}
Expand Down
1 change: 1 addition & 0 deletions tools/cli/internal/openapi/openapi.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ type Spec struct {
Components *openapi3.Components `json:"components,omitempty" yaml:"components,omitempty"`
ExternalDocs *openapi3.ExternalDocs `json:"externalDocs,omitempty" yaml:"externalDocs,omitempty"`
}

type Parser interface {
CreateOpenAPISpecFromPath(string) (*load.SpecInfo, error)
}
Expand Down
18 changes: 14 additions & 4 deletions tools/postman/scripts/upload-collection.sh
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,11 @@ pushd "${OPENAPI_FOLDER}"
current_collection_name="⭐MongoDB Atlas Administration API ${current_api_revision}"

echo "Fetching list of current collections"
echo "curl -o ${COLLECTIONS_LIST_FILE}
echo "curl -o ${COLLECTIONS_LIST_FILE}
--location 'https://api.getpostman.com/collections?workspace=${WORKSPACE_ID}'
--header 'X-API-Key: **********'"
curl --show-error --fail --silent -o "${COLLECTIONS_LIST_FILE}" \
curl --show-error \
--fail --silent -o "${COLLECTIONS_LIST_FILE}" \
--location "https://api.getpostman.com/collections?workspace=${WORKSPACE_ID}" \
--header "X-API-Key: ${POSTMAN_API_KEY}"

Expand Down Expand Up @@ -63,7 +64,11 @@ if [ "$collection_exists" = "false" ]; then
--header 'Content-Type: application/json'
--header 'X-API-Key: **********'
--data ${collection_transformed_path}"
curl --show-error --fail --retry 5 --retry-all-errors --silent \
curl --show-error \
--fail \
--retry 5 \
--retry-all-errors \
--silent \
--location "https://api.getpostman.com/collections?workspace=${WORKSPACE_ID}" \
--header "Content-Type: application/json" \
--header "X-API-Key: ${POSTMAN_API_KEY}" \
Expand All @@ -80,7 +85,12 @@ else
--header 'X-API-Key: **********'
--data ${collection_transformed_path}"

curl --show-error --fail --retry 5 --retry-all-errors --silent --request PUT \
curl --show-error \
--fail \
--retry 5 \
--retry-all-errors \
--silent \
--request PUT \
--location "https://api.getpostman.com/collections/${collection_id}" \
--header "Content-Type: application/json" \
--header "X-API-Key: ${POSTMAN_API_KEY}" \
Expand Down
Loading