-
Notifications
You must be signed in to change notification settings - Fork 245
Add serverless: forbid for collection management tests #1216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. I didn't catch these failures in Go because we only run a subset of unified tests against serverless; I assume Java is running all, @jyemin ?
I think you should also forbid serverless on timeseries-collection
and modifyCollection-pre_and_post_images
, too.
Java runs all unified tests on serverless, and relies on runOnRequirements to restrict. Everyone should do this IMO.
Those tests are not failing so I didn't change them. Is time series not supported on serverless? I don't know why modify... is succeeded, but it seems to be. |
Filed GODRIVER-2421. You are correct, and it says so in the spec for serverless testing here. As long as the timeseries tests aren't failing I suppose it's fine to allow serverless on them. Go does not run the |
Added serverless restriction to modify collection test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM
@jyemin: Was there a DRIVERS ticket for this change? I assume the new commit will be relevant for drivers to sync to. If there will be a ticket created for this, I think it'd also be a good opportunity to knock out DRIVERS-2325 since the same test file will be synced. |
Please complete the following before merging:
Not sure why this wasn't caught in initial testing, but serverless tests are failing in Java driver.