DRIVERS-2124: Remove tests for undefined _id values #1713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The server does not allow _id values to be undefined, nor does it allow comparisons to undefined. Follow-up to 83b2938
jmikola
commented
Nov 1, 2024
| @@ -95,75 +95,3 @@ tests: | |||
| object: *collection | |||
| arguments: {filter: *null_id_filter} | |||
| expectResult: 1 | |||
|
|
|||
| - description: inserting _id with type undefined via insertOne | |||
There was a problem hiding this comment.
@nbbeeken: I assume these failures were missed in the original PR because Node silently converts undefined to null. In any event, undefined was never in the original scope of DRIVERS-2124 so let's just forget about this.
There was a problem hiding this comment.
Yep, exactly right, good catch thanks for fixing this so quick!
This was referenced Nov 1, 2024
nbbeeken
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/DRIVERS-2124
The server does not allow _id values to be undefined, nor does it allow comparisons to undefined:
I observed test failures in PHPLIB (see: Evergreen task, which correlate with the following errors in the server:
Follow-up to #1699