-
Notifications
You must be signed in to change notification settings - Fork 192
doc: Updates Cedar action names and namespaces for Public Preview. #3017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4744ef6
to
5da8be4
Compare
Nice. Looks like we are missing updates to |
FYI @EspenAlbert if you'd like to have a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for handling this! 🙏 Left one comment on a policy scheme name change.
As for release, the new schema is planned to go live in production sometime Wednesday, Feb 5th. So, anytime between Wednesday (2/5) and Friday (2/7) is good to be released.
forbid ( | ||
principal, | ||
action == cloud::Action::"cluster.createEdit", | ||
action == ResourcePolicy::Action::"cluster.modify", | ||
resource | ||
) | ||
when |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not able to comment on the below line since it's not appearing in the "modified" section, but the when clause should have ResourcePolicy::CloudProvider::"${CLOUD_PROVIDER}"
instead of cloud::cloudProvider::"${CLOUD_PROVIDER}"
:
{ context.cluster.cloudProviders.containsAny([ResourcePolicy::CloudProvider::"${CLOUD_PROVIDER}"]) };
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thank you!
@@ -7,7 +7,7 @@ resource "mongodbatlas_resource_policy" "project_ip_access_list" { | |||
body = <<EOF | |||
forbid ( | |||
principal, | |||
action == cloud::Action::"project.edit", | |||
action == ResourcePolicy::Action::"project.ipAccessList.modify", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we are also mentioning Private instead of Public preview in the README.md
in this directory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor comment left.
Thank you for handling this 🚀
Please wait on merging until after Wednesday (2/5) as mentioned by @jxiao
(hopefully) last update: the v20250205 release has been postponed to Thursday, 2/6. Could we hold off on deploying this until Thursday afternoon? Thanks! |
@erabil-mdb is this good to merge from your end? |
Description
Updates
cloud
namespace toResourcePolicy
.Updates
project.edit
action toproject.ipAccessList.modify
.Updates
cluster.createEdit
tocluster.modify
.Updates "Private Preview" to "Public Preview".
Link to any related issue(s):
https://jira.mongodb.org/browse/CLOUDP-290399
https://jira.mongodb.org/browse/DOCSP-46040
Type of change:
Required Checklist:
Further comments