Skip to content

doc: Updates Cedar action names and namespaces for Public Preview. #3017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 6, 2025

Conversation

erabil-mdb
Copy link
Contributor

@erabil-mdb erabil-mdb commented Jan 31, 2025

Description

Updates cloud namespace to ResourcePolicy.
Updates project.edit action to project.ipAccessList.modify.
Updates cluster.createEdit to cluster.modify.
Updates "Private Preview" to "Public Preview".

Link to any related issue(s):
https://jira.mongodb.org/browse/CLOUDP-290399
https://jira.mongodb.org/browse/DOCSP-46040

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@erabil-mdb erabil-mdb requested a review from a team as a code owner January 31, 2025 21:03
@EspenAlbert
Copy link
Collaborator

Nice. Looks like we are missing updates to templates/data-sources/resource_policy.md.tmpl and running make generate-docs-all. Let me know if you need assistance with the make commands 😁

@marcosuma
Copy link
Collaborator

FYI @EspenAlbert if you'd like to have a look

Copy link

@jxiao jxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling this! 🙏 Left one comment on a policy scheme name change.

As for release, the new schema is planned to go live in production sometime Wednesday, Feb 5th. So, anytime between Wednesday (2/5) and Friday (2/7) is good to be released.

Comment on lines 1 to 6
forbid (
principal,
action == cloud::Action::"cluster.createEdit",
action == ResourcePolicy::Action::"cluster.modify",
resource
)
when
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not able to comment on the below line since it's not appearing in the "modified" section, but the when clause should have ResourcePolicy::CloudProvider::"${CLOUD_PROVIDER}" instead of cloud::cloudProvider::"${CLOUD_PROVIDER}":

{ context.cluster.cloudProviders.containsAny([ResourcePolicy::CloudProvider::"${CLOUD_PROVIDER}"]) };

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Updated.

@erabil-mdb erabil-mdb requested a review from a team as a code owner February 3, 2025 21:18
Copy link
Contributor

@corryroot corryroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@jxiao jxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you! :shipit:

@@ -7,7 +7,7 @@ resource "mongodbatlas_resource_policy" "project_ip_access_list" {
body = <<EOF
forbid (
principal,
action == cloud::Action::"project.edit",
action == ResourcePolicy::Action::"project.ipAccessList.modify",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we are also mentioning Private instead of Public preview in the README.md in this directory

Copy link
Collaborator

@EspenAlbert EspenAlbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment left.
Thank you for handling this 🚀
Please wait on merging until after Wednesday (2/5) as mentioned by @jxiao

@jxiao
Copy link

jxiao commented Feb 4, 2025

(hopefully) last update: the v20250205 release has been postponed to Thursday, 2/6. Could we hold off on deploying this until Thursday afternoon? Thanks!

@maastha
Copy link
Collaborator

maastha commented Feb 6, 2025

@erabil-mdb is this good to merge from your end?

@erabil-mdb erabil-mdb merged commit cacb830 into mongodb:master Feb 6, 2025
40 checks passed
@erabil-mdb erabil-mdb deleted the DOCSP-290399 branch February 6, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants