Skip to content

chore: Adds "state_name" to keepUnknown list to prevent copying volatile attributes from state #3040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2025
Merged

chore: Adds "state_name" to keepUnknown list to prevent copying volatile attributes from state #3040

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/service/advancedclustertpf/plan_modifier.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ func useStateForUnknowns(ctx context.Context, diags *diag.Diagnostics, plan, sta
}

func determineKeepUnknowns(upgradeRequest *admin.LegacyAtlasTenantClusterUpgradeRequest, patchReq *admin.ClusterDescription20240805) []string {
keepUnknown := []string{"connection_strings"} // ConnectionStrings is volatile and should not be copied from state
keepUnknown := []string{"connection_strings", "state_name"} // Volatile attributes, should not be copied from state
if upgradeRequest != nil {
// TenantUpgrade changes a few root level fields that are normally ok to use state values for
keepUnknown = append(keepUnknown, "disk_size_gb", "cluster_id", "replication_specs", "backup_enabled", "create_date")
Expand Down