feat(search deployments): add no_wait_for_state_transition parameter to skip reindexing wait

[ridmagroupby]

Description

This PR introduces a new optional parameter, no_wait_for_state_transition, to the mongodbatlas_search_deployment resource. This new feature allows Terraform to update search nodes without waiting for all reindexing operations to complete.

When creating search nodes, the default behavior is acceptable; however, when modifying search nodes that already have many indexes, waiting for the complete reindexing process can take a long time and incur significant pipeline costs. With this change, if no_wait_for_state_transition is set to true, Terraform will trigger the update and return immediately, allowing reindexing to continue in the background. The default value remains false to ensure backward compatibility.

Link to any related issue(s): HELP-71754

Type of change

• Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
• New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
• Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
• This change requires a documentation update.
• Documentation fix/enhancement.

Required Checklist

• I have signed the MongoDB CLA.
• I have read the contributing guides.
• I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
• I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements.
• I have added any necessary documentation (if appropriate).
• I have run make fmt and formatted my code.
• If changes include deprecations or removals I have added appropriate changelog entries.
• If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. (Reach out to the APIx Integration slack channel to get access to the internal document.)

Further comments

No further comments.

[github-actions]

This PR has gone 7 days without any activity and meets the project’s definition of "stale". This will be auto-closed if there is no new activity over the next 7 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy!

[themantissa]

Thank you @ridmagroupby for the PR. We are discussing the it with the team and will get back to you soon.

[github-actions]

This PR has gone 7 days without any activity and meets the project’s definition of "stale". This will be auto-closed if there is no new activity over the next 7 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy!

[ridmagroupby]

bump

[github-actions]

This PR has gone 7 days without any activity and meets the project’s definition of "stale". This will be auto-closed if there is no new activity over the next 7 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy!

[marcosuma]

Re-opening this issue while we still discuss internally. Apologies for further waiting on a decision here.

[github-actions]

This PR has gone 7 days without any activity and meets the project’s definition of "stale". This will be auto-closed if there is no new activity over the next 7 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy!

[ridmagroupby]

bump

[github-actions]

This PR has gone 7 days without any activity and meets the project’s definition of "stale". This will be auto-closed if there is no new activity over the next 7 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy!

[marcosuma]

Hi @ridmagroupby, once again thank you for your patience. Our team has reached a decision and we are going to move forward with this proposal. We'll make few changes to your proposal, such as changing the name of the field and add some clarity on the documentation. We want to make sure the usage of the field will be intuitive for everyone and be clear on "what it means" when customers use it.
Lastly, our engineer @EspenAlbert will take care of it. Because of our testing infrastructure, we'll need to work on a separate PR and he will add you as a contributor to that by cherry-picking some of your commits.

Let me know if you have any questions, and thank you for your contributions.

[ridmagroupby]

@marcosuma @EspenAlbert thanks a lot for considering it. Please keep me in the loop if possible and lemme know if I can be any help further. I guess thats it for this PR then . Cheers thanks a lot !!!

[github-actions]

This PR has gone 7 days without any activity and meets the project’s definition of "stale". This will be auto-closed if there is no new activity over the next 7 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy!

[EspenAlbert]

Merged in #3237 Thank you @ridmagroupby

[marcosuma]

Hi @ridmagroupby thank you once again for your PR and patience. Your change has been included with #3237 like Espen said. This should be out by the end of the week.