-
Notifications
You must be signed in to change notification settings - Fork 189
feat: Adds encryption_at_rest_provider
to mongodbatlas_search_deployment
resource and data source
#3152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adds encryption_at_rest_provider
to mongodbatlas_search_deployment
resource and data source
#3152
Changes from 9 commits
d2af575
0a52f8c
6110c3c
befef8a
4319906
c6d3130
81b0ce0
24ca735
b5a3dff
b83f556
6c30a41
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
```release-note:enhancement | ||
resource/mongodbatlas_search_deployment: Adds `encryption_at_rest_provider` computed attribute | ||
``` | ||
|
||
```release-note:enhancement | ||
data-source/mongodbatlas_search_deployment: Adds `encryption_at_rest_provider` computed attribute | ||
``` |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
package searchdeployment | ||
|
||
import ( | ||
"github.com/hashicorp/terraform-plugin-framework/types" | ||
) | ||
|
||
type TFSearchDeploymentDSModel struct { | ||
ID types.String `tfsdk:"id"` | ||
ClusterName types.String `tfsdk:"cluster_name"` | ||
ProjectID types.String `tfsdk:"project_id"` | ||
Specs types.List `tfsdk:"specs"` | ||
StateName types.String `tfsdk:"state_name"` | ||
EncryptionAtRestProvider types.String `tfsdk:"encryption_at_rest_provider"` | ||
} |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,14 +12,13 @@ import ( | |
func TestMigSearchDeployment_basic(t *testing.T) { | ||
var ( | ||
resourceName = "mongodbatlas_search_deployment.test" | ||
orgID = os.Getenv("MONGODB_ATLAS_ORG_ID") | ||
projectName = acc.RandomProjectName() | ||
projectID = os.Getenv("MONGODB_ATLAS_PROJECT_EAR_PE_AWS_ID") // to use RequirePrivateNetworking, Atlas Project is required to have FF enabled | ||
clusterName = acc.RandomClusterName() | ||
instanceSize = "S30_HIGHCPU_NVME" | ||
searchNodeCount = 3 | ||
config = configBasic(orgID, projectName, clusterName, instanceSize, searchNodeCount) | ||
config = configBasic(projectID, clusterName, instanceSize, searchNodeCount) | ||
) | ||
mig.SkipIfVersionBelow(t, "1.13.0") | ||
mig.SkipIfVersionBelow(t, "1.30.0") // encryption_at_rest_provider was added in 1.30.0 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are we sure this feat will be released in 1.30? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good point, added a comment in CLOUDP-296693 specifying what needs to be done before we merge the dev branch to master and included TODO in b83f556 so that it's harder to miss |
||
resource.ParallelTest(t, resource.TestCase{ | ||
PreCheck: func() { mig.PreCheckBasic(t) }, | ||
CheckDestroy: checkDestroy, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: You can consider refactoring to use
DataSourceSchemaFromResource
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But
DataSourceSchemaFromResource
is for the resource schema, not the TF models? I tried to useTFSearchDeploymentRSModel
everywhere, but the resource model has the timeout attribute, and it should not be in the data source