refactor: Updates advanced_cluster tpf plan_modifier auto_scaling removed logic

[EspenAlbert]

Description

Updates advanced_cluster tpf plan_modifier auto_scaling removed logic

Link to any related issue(s): CLOUDP-308779

Type of change:

• Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
• New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
• Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
• This change requires a documentation update
• Documentation fix/enhancement

Required Checklist:

• I have signed the MongoDB CLA
• I have read the contributing guides
• I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
• I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
• I have added any necessary documentation (if appropriate)
• I have run make fmt and formatted my code
• If changes include deprecations or removals I have added appropriate changelog entries.
• If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

[lantoli]

this is only called if plan is unknown, right?

nice the new approach, less verbose and easier to understand

[EspenAlbert]

Correct 👍

[lantoli]

the logic to affect other elements when autoscale is enabled, e.g. keepUnkownFuncWithNonEmptyAutoScaling is not implemented yet, is that correct?

[EspenAlbert]

Correct, not implemented. Will be done in CLOUDP-308783

[EspenAlbert]

Continued in #3218