Skip to content

feat: add support for datadog metrics in third_party_integration #3253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

francovp
Copy link

@francovp francovp commented Apr 6, 2025

Description

Adds support for sendCollectionLatencyMetrics and sendDatabaseMetrics in the Datadog third_party_integration resource and data sources as they are supported by the atlas API

Updates documentation and example configurations to reflect these new options.

Link to any related issue(s):

https://feedback.mongodb.com/forums/924145-atlas/suggestions/49619627-add-sendcollectionlatencymetrics-and-senddatabasem

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

Adds support for `sendCollectionLatencyMetrics` and `sendDatabaseMetrics` in the Datadog `third_party_integration` resource and data sources as they are supported by the atlas API

Updates documentation and example configurations to reflect these new options.
@francovp francovp requested review from a team as code owners April 6, 2025 02:22
@maastha
Copy link
Collaborator

maastha commented Apr 7, 2025

Thanks a lot @francovp for creating this PR!

As per our guidelines, I will work on running our tests & incorporating this change into our provider.

Copy link
Contributor

This PR has gone 7 days without any activity and meets the project’s definition of "stale". This will be auto-closed if there is no new activity over the next 7 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy!

@github-actions github-actions bot added the stale label Apr 13, 2025
@francovp
Copy link
Author

Closing as this was implemented in #3259

@francovp francovp closed this Apr 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants