feat: Adds support for security contact in mongodbatlas_organization resource & data sources
#3263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maastha
commented
Apr 9, 2025
| @@ -38,42 +51,18 @@ func TestAccConfigRSOrganization_Basic(t *testing.T) { | |||
| Steps: []resource.TestStep{ | |||
| { | |||
| Config: configBasic(orgOwnerID, name, description, roleName, false, nil), | |||
| Check: resource.ComposeAggregateTestCheckFunc( | |||
There was a problem hiding this comment.
refactored checks into common functions
|
APIx bot: a message has been sent to Docs Slack channel |
lantoli
reviewed
Apr 9, 2025
.changelog/3263.txt
Outdated
| @@ -0,0 +1,11 @@ | |||
| ```release-note:enhancement | |||
| resource/mongodbatlas_organization: Adds new `security_contact` attribute` | |||
There was a problem hiding this comment.
nit: 'new' is redundant and can be dropped in all notes. also there is a wrong tick at the end of all messages
lantoli
reviewed
Apr 9, 2025
| RestrictEmployeeAccess: conversion.Pointer(false), | ||
| GenAIFeaturesEnabled: conversion.Pointer(true), | ||
| } | ||
| ) | ||
|
|
||
| func TestAccConfigRSOrganization_Basic(t *testing.T) { | ||
| acc.SkipTestForCI(t) // affects the org |
There was a problem hiding this comment.
no, it needs paying organizations to create new ones & dev is unstable when deleting orgs at this point as well
lantoli
approved these changes
Apr 9, 2025
EspenAlbert
reviewed
Apr 10, 2025
| "multi_factor_auth_required": strconv.FormatBool(*settings.MultiFactorAuthRequired), | ||
| "restrict_employee_access": strconv.FormatBool(*settings.RestrictEmployeeAccess), | ||
| "gen_ai_features_enabled": strconv.FormatBool(*settings.GenAIFeaturesEnabled), | ||
| "security_contact": settings.GetSecurityContact(), |
There was a problem hiding this comment.
Surprises me a bit that we check the empty string "" and it works. Would expect it to be null in the state when it doesn't exist. 🤔 probably because it is SDKv2
There was a problem hiding this comment.
yes my understanding is that it's due to SDKv2
EspenAlbert
approved these changes
Apr 10, 2025
carriecwk
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for security contact in
mongodbatlas_organizationresource & data sourcesLink to any related issue(s): CLOUDP-286563
Type of change:
Required Checklist:
Further comments