Skip to content

Bump to SQL*Server 15 (2019) CU32 (ubuntu 20.04) #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bump to SQL*Server 15 (2019) CU32 (ubuntu 20.04) #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- name: Run tests
run: |
# Verify we have a working SQL server.
docker exec test0 /opt/mssql-tools/bin/sqlcmd -U sa -P m@0dl3ing -Q "SELECT @@VERSION" | grep "Microsoft SQL Server"
docker exec test0 /opt/mssql-tools18/bin/sqlcmd -C -U sa -P m@0dl3ing -Q "SELECT @@VERSION" | grep "Microsoft SQL Server"

- name: Output logs
if: ${{ failure() }}
Expand Down
7 changes: 5 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM mcr.microsoft.com/mssql/server:2019-CU22-ubuntu-20.04
FROM mcr.microsoft.com/mssql/server:2019-CU32-ubuntu-20.04


# Starting with SQL*Server 2017-CU6, by default, flushing became
Expand All @@ -17,10 +17,13 @@ FROM mcr.microsoft.com/mssql/server:2019-CU22-ubuntu-20.04
# Complete phpunit runs:
# - 2019-CU18: 4h 38m
# - 2019-CU18 + this patch: 1h 33m
#
# Besides, disable SQL Server forcing all connections to be encrypted.
USER root
RUN /opt/mssql/bin/mssql-conf traceflag 3979 on && \
/opt/mssql/bin/mssql-conf set control.alternatewritethrough 0 && \
/opt/mssql/bin/mssql-conf set control.writethrough 0
/opt/mssql/bin/mssql-conf set control.writethrough 0 && \
/opt/mssql/bin/mssql-conf set network.forceencryption 0

ADD root/ /

Expand Down
2 changes: 1 addition & 1 deletion root/setup-db-for-moodle.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ set -e
./wait-for-mssql-to-come-up.sh

echo "[moodle-db-mssql] Setting up Moodle data"
/opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P $SA_PASSWORD -d master -i setup.sql
/opt/mssql-tools18/bin/sqlcmd -C -S localhost -U sa -P $SA_PASSWORD -d master -i setup.sql
echo "[moodle-db-mssql] Setup complete."
2 changes: 1 addition & 1 deletion root/wait-for-mssql-to-come-up.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
set -e

i=0
until /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P "$SA_PASSWORD" -d master -l 1 -Q "SELECT 1" > /dev/null 2>&1
until /opt/mssql-tools18/bin/sqlcmd -C -S localhost -U sa -P "$SA_PASSWORD" -d master -l 1 -Q "SELECT 1" > /dev/null 2>&1
do
echo "[moodle-db-mssql] Waiting for SQL to accept connections"
sleep 1
Expand Down