Skip to content

Upgrade to Polkadot-sdk v1.3.0 #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2023
Merged

Upgrade to Polkadot-sdk v1.3.0 #6

merged 1 commit into from
Nov 28, 2023

Conversation

ahmadkaouk
Copy link

No description provided.

@ahmadkaouk ahmadkaouk changed the title Upgrade to polkadot-v1.3.0 Upgrade to Polkadot-sdk v1.3.0 Nov 20, 2023
@ahmadkaouk ahmadkaouk marked this pull request as ready for review November 21, 2023 09:42
@rimbi
Copy link

rimbi commented Nov 28, 2023

I think you should apply these changes not only to Cargo.dev.toml but also to all other Cargo.toml files.

@ahmadkaouk
Copy link
Author

I think you should apply these changes not only to Cargo.dev.toml but also to all other Cargo.toml files.

This is no longer necessary because they recently updated all the Cargo.toml files to use the workspace dependencies
(open-web3-stack#960) .

rimbi
rimbi approved these changes Nov 28, 2023
View reviewed changes
Copy link

@rimbi rimbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@ahmadkaouk ahmadkaouk merged commit 0bff267 into moonbeam-polkadot-v1.3.0 Nov 28, 2023
@ahmadkaouk ahmadkaouk deleted the ahmad-polkadot-v1.3.0 branch November 28, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rimbi rimbi rimbi approved these changes

@librelois librelois Awaiting requested review from librelois

@Agusrodri Agusrodri Awaiting requested review from Agusrodri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahmadkaouk @rimbi