Skip to content

No warning when a top level test has no subtests #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2020

Conversation

moricho
Copy link
Owner

@moricho moricho commented Sep 21, 2020

If a top-level test has no subtests, tparallel should not warn regardless of whether t.Parallel() is called or not.

fixes #8

@moricho moricho merged commit 88fabab into master Sep 21, 2020
@moricho moricho deleted the fix/without-subtests branch September 21, 2020 06:20
@moricho
Copy link
Owner Author

moricho commented Sep 21, 2020

Related to this PR
golangci/golangci-lint#1380

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive on tests without subtests
1 participant